Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Leo6Leo as eventing approver #1600

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Add Leo6Leo as eventing approver #1600

merged 4 commits into from
Aug 7, 2024

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Aug 1, 2024 •
edited
Loading

Changes

  • Add @Leo6Leo as an eventing approver (follow up on the Eventing WG meeting)

cc @pierDipi

@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 1, 2024

@Leo6Leo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Add @Leo6Leo as an eventing approver (follow up on the Eventing WG meeting with)

cc @pierDipi

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2024
@Leo6Leo
Copy link
Member Author

Leo6Leo commented Aug 1, 2024

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi August 1, 2024 17:03
@dsimansk
Copy link
Contributor

dsimansk commented Aug 1, 2024 •
edited
Loading

/approve
/lgtm

/hold for @pierDipi to confirm

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2024
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 1, 2024
@aliok
Copy link
Member

aliok commented Aug 5, 2024

/lgtm
/approve

pierDipi
pierDipi approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @Leo6Leo

/lgtm
/approve

@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dsimansk, Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member

Cali0707 commented Aug 6, 2024

@dsimansk @pierDipi can we unhold the PR?

@Cali0707
Copy link
Member

Cali0707 commented Aug 7, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2024
@Cali0707
Copy link
Member

Cali0707 commented Aug 7, 2024

Congrats @Leo6Leo - well deserved!!! 🎉

@knative-prow knative-prow bot merged commit 36692c9 into knative:main Aug 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@dprotaso dprotaso Awaiting requested review from dprotaso

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@aliok aliok

@dsimansk dsimansk

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Leo6Leo @dsimansk @aliok @Cali0707 @pierDipi