Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brew command for kn #4176

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Conversation

sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Sep 3, 2021

a formulae was merged in homebrew core to install kn without a specific tap

a formulae was merged in homebrew core to install kn without a specific tap
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 3, 2021
@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: a844d25

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/6138a33000fa5f00079ab607

😎 Browse the preview: https://deploy-preview-4176--knative.netlify.app

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2021
@@ -4,7 +4,7 @@
For macOS, you can install `kn` by using [Homebrew](https://github.com/knative/homebrew-client){target=_blank}.
Copy link
Contributor

@antoineco antoineco Sep 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still relevant, now that kn can be installed from the main Homebrew tap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue in the homebrew-client repo knative/homebrew-client#32 and I will updated this PR.

you are correct we don't need this homebrew client repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the URL with the one of brew main page.

docs/snippets/install-kn.md Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 7, 2021
@knative-prow-robot knative-prow-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 8, 2021
@sebgoa
Copy link
Contributor Author

sebgoa commented Sep 8, 2021

/assign @omerbensaadon

@sebgoa
Copy link
Contributor Author

sebgoa commented Sep 8, 2021

I solved the conflict

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@omerbensaadon
Copy link

/approve
/cherry-pick release-0.25

@knative-prow-robot
Copy link
Contributor

@omerbensaadon: once the present PR merges, I will cherry-pick it on top of release-0.25 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-0.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omerbensaadon
Copy link

thanks @sebgoa!!

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, omerbensaadon, sebgoa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@knative-prow-robot knative-prow-robot merged commit 48104fe into knative:mkdocs Sep 8, 2021
@knative-prow-robot
Copy link
Contributor

@omerbensaadon: #4176 failed to apply on top of branch "release-0.25":

Applying: update brew command for kn
Using index info to reconstruct a base tree...
M	docs/snippets/install-kn.md
Falling back to patching base and 3-way merge...
Auto-merging docs/snippets/install-kn.md
Applying: Update docs/snippets/install-kn.md
Using index info to reconstruct a base tree...
M	docs/snippets/install-kn.md
Falling back to patching base and 3-way merge...
Auto-merging docs/snippets/install-kn.md
CONFLICT (content): Merge conflict in docs/snippets/install-kn.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Update docs/snippets/install-kn.md
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/approve
/cherry-pick release-0.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants