Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go.uber.org/atomic from 1.9.0 to 1.11.0 #2773

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 28, 2023

Bumps go.uber.org/atomic from 1.9.0 to 1.11.0.

Release notes

Sourced from go.uber.org/atomic's releases.

v1.11.0

Fixed

  • Fix Swap and CompareAndSwap for Value wrappers without initialization.

Added

  • Add String method to atomic.Pointer[T] type allowing users to safely print underlying values of pointers.

v1.10.0

Added

  • Add atomic.Float32 type for atomic operations on float32.
  • Add CompareAndSwap and Swap methods to atomic.String, atomic.Error, and atomic.Value.
  • Add generic atomic.Pointer[T] type for atomic operations on pointers of any type. This is present only for Go 1.18 or higher, and is a drop-in for replacement for the standard library's sync/atomic.Pointer type.

Changed

  • Deprecate CAS methods on all types in favor of corresponding CompareAndSwap methods.

Thanks to @​eNV25 and @​icpd for their contributions to this release.

Changelog

Sourced from go.uber.org/atomic's changelog.

1.11.0 - 2023-05-02

Fixed

  • Fix Swap and CompareAndSwap for Value wrappers without initialization.

Added

  • Add String method to atomic.Pointer[T] type allowing users to safely print underlying values of pointers.

1.10.0 - 2022-08-11

Added

  • Add atomic.Float32 type for atomic operations on float32.
  • Add CompareAndSwap and Swap methods to atomic.String, atomic.Error, and atomic.Value.
  • Add generic atomic.Pointer[T] type for atomic operations on pointers of any type. This is present only for Go 1.18 or higher, and is a drop-in for replacement for the standard library's sync/atomic.Pointer type.

Changed

  • Deprecate CAS methods on all types in favor of corresponding CompareAndSwap methods.

Thanks to @​eNV25 and @​icpd for their contributions to this release.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 28, 2023
@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 28, 2023
@knative-prow knative-prow bot requested review from kauana and ReToCode July 28, 2023 13:44
@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (4866914) 81.82% compared to head (323958b) 81.78%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2773      +/-   ##
==========================================
- Coverage   81.82%   81.78%   -0.04%     
==========================================
  Files         167      167              
  Lines       10201    10201              
==========================================
- Hits         8347     8343       -4     
- Misses       1608     1612       +4     
  Partials      246      246              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor

nak3 commented Jul 31, 2023

@dependabot rebase

Bumps [go.uber.org/atomic](https://github.com/uber-go/atomic) from 1.9.0 to 1.11.0.
- [Release notes](https://github.com/uber-go/atomic/releases)
- [Changelog](https://github.com/uber-go/atomic/blob/master/CHANGELOG.md)
- [Commits](uber-go/atomic@v1.9.0...v1.11.0)

---
updated-dependencies:
- dependency-name: go.uber.org/atomic
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/go.uber.org/atomic-1.11.0 branch from dd06689 to 5a4d5e0 Compare July 31, 2023 14:41
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 31, 2023
@jarias-lfx
Copy link

/easycla

@nak3
Copy link
Contributor

nak3 commented Aug 1, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2023
@nak3 nak3 closed this Aug 1, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 1, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@nak3 nak3 reopened this Aug 1, 2023
@nak3 nak3 closed this Aug 1, 2023
@nak3 nak3 reopened this Aug 1, 2023
@dependabot dependabot bot closed this Aug 1, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/go.uber.org/atomic-1.11.0 branch August 1, 2023 01:41
@nak3 nak3 restored the dependabot/go_modules/go.uber.org/atomic-1.11.0 branch August 1, 2023 01:41
@nak3 nak3 reopened this Aug 1, 2023
@nak3
Copy link
Contributor

nak3 commented Aug 2, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@nak3
Copy link
Contributor

nak3 commented Aug 2, 2023

/hold

I think we can stop using go.uber.org/atomic.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Aug 2, 2023

has been replaced with #2777

@krsna-m krsna-m closed this Aug 2, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/go.uber.org/atomic-1.11.0 branch August 2, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. go Pull requests that update Go code lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants