Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/kubernetes to fix vulnerabilities #638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhangguanzhang
Copy link

namely 1.27.15 because of the following vulnerabilities:

namely 1.27.15 because of the following vulnerabilities:
 * CVE-2023-5528 was fixed in 1.26.11.
 * CVE-2024-3177 was fixed in 1.27.13.

Signed-off-by: zhangguanzhang <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @zhangguanzhang!

It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @zhangguanzhang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn July 3, 2024 14:06
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhangguanzhang
Once this PR has been reviewed and has the lgtm label, please assign mrhohn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 3, 2024
@DamianSawicki
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2024
@DamianSawicki
Copy link
Collaborator

/retest

@zhangguanzhang
Copy link
Author

/test pull-kubernetes-dns-test

@VikashLNU
Copy link

VikashLNU commented Oct 4, 2024

Hi @zhangguanzhang
When are you targeting to merge this fix. We are using this package in one of the app container which is flagging GHSA-hq6q-c2x6-hmch findings.
Thanks

@zhangguanzhang
Copy link
Author

Hi @zhangguanzhang When are you targeting to merge this fix. We are using this package in one of the app container which is flagging GHSA-hq6q-c2x6-hmch findings. Thanks

CI unit tests fail, the error information is not detailed enough, and no developer follows up on the issue

@DamianSawicki
Copy link
Collaborator

@zhangguanzhang You are the PR author, so it is expected that you would investigate a test failing on it. I see the test failed three times on July 23rd, July 29th, and September 14th with the exact same error message

Running Suite: k8s-dns e2e test suite
=====================================
Random Seed: 1721761545
Will run 5 of 5 specs
2024/07/23 19:06:06 exit status 1
Ginkgo ran 1 suite in 20.388274658s
Test Suite Failed

so it does not look like test flakiness.

@DamianSawicki
Copy link
Collaborator

/retest

@k8s-ci-robot
Copy link
Contributor

@zhangguanzhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-dns-test 7ee6828 link true /test pull-kubernetes-dns-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zhangguanzhang
Copy link
Author

@zhangguanzhang You are the PR author, so it is expected that you would investigate a test failing on it. I see the test failed three times on July 23rd, July 29th, and September 14th with the exact same error message

Running Suite: k8s-dns e2e test suite
=====================================
Random Seed: 1721761545
Will run 5 of 5 specs
2024/07/23 19:06:06 exit status 1
Ginkgo ran 1 suite in 20.388274658s
Test Suite Failed

so it does not look like test flakiness.

The error message from CI is not detailed enough, and I don't have a clue how to troubleshoot it.

@DamianSawicki
Copy link
Collaborator

It turns out that this test fails identically for an empty PR, so there is something wrong with tests, and this PR may be perfectly correct. I opened issue #646.

@VikashLNU
Copy link

Hi @DamianSawicki @zhangguanzhang
Is there any ETA when this fix will be merged or any ticket that we can track for the fix deployment.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants