Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlint: Refuse quoted build_style #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamiKettunen
Copy link
Contributor

I'm wondering if this should be even more strict for some other variables as well.

So far only around 83 packages currently in void-packages will be affected by this change as per xlint $(find srcpkgs -name template) | grep 'build_style must not be quoted':

Clock to show/hide the 83 package results
srcpkgs/xsel/template:5: build_style must not be quoted
srcpkgs/xfig/template:5: build_style must not be quoted
srcpkgs/xcalib/template:5: build_style must not be quoted
srcpkgs/wicd/template:6: build_style must not be quoted
srcpkgs/wavemon/template:5: build_style must not be quoted
srcpkgs/volta/template:6: build_style must not be quoted
srcpkgs/urxvtconfig/template:6: build_style must not be quoted
srcpkgs/tlpui/template:5: build_style must not be quoted
srcpkgs/texlive-science/template:5: build_style must not be quoted
srcpkgs/texlive-publishers/template:5: build_style must not be quoted
srcpkgs/texlive-pstricks/template:5: build_style must not be quoted
srcpkgs/texlive-pictures/template:5: build_style must not be quoted
srcpkgs/texlive-music/template:5: build_style must not be quoted
srcpkgs/texlive-latexextra/template:5: build_style must not be quoted
srcpkgs/texlive-langkorean/template:5: build_style must not be quoted
srcpkgs/texlive-langjapanese/template:5: build_style must not be quoted
srcpkgs/texlive-langgreek/template:5: build_style must not be quoted
srcpkgs/texlive-langextra/template:5: build_style must not be quoted
srcpkgs/texlive-langcyrillic/template:5: build_style must not be quoted
srcpkgs/texlive-langchinese/template:5: build_style must not be quoted
srcpkgs/texlive-humanities/template:5: build_style must not be quoted
srcpkgs/texlive-games/template:5: build_style must not be quoted
srcpkgs/texlive-formatsextra/template:5: build_style must not be quoted
srcpkgs/texlive-fontsextra/template:5: build_style must not be quoted
srcpkgs/texlive-core/template:5: build_style must not be quoted
srcpkgs/texlive-bibtexextra/template:5: build_style must not be quoted
srcpkgs/texi2html/template:5: build_style must not be quoted
srcpkgs/t1utils/template:5: build_style must not be quoted
srcpkgs/sway-audio-idle-inhibit/template:5: build_style must not be quoted
srcpkgs/sv-netmount/template:5: build_style must not be quoted
srcpkgs/sunxi-tools/template:6: build_style must not be quoted
srcpkgs/ssh-audit/template:5: build_style must not be quoted
srcpkgs/spt/template:10: build_style must not be quoted
srcpkgs/slurm/template:5: build_style must not be quoted
srcpkgs/sklogw/template:11: build_style must not be quoted
srcpkgs/scons/template:5: build_style must not be quoted
srcpkgs/sacc/template:5: build_style must not be quoted
srcpkgs/rust-bindgen/template:5: build_style must not be quoted
srcpkgs/runit/template:6: build_style must not be quoted
srcpkgs/rbw/template:6: build_style must not be quoted
srcpkgs/rbenv/template:5: build_style must not be quoted
srcpkgs/python3/template:8: build_style must not be quoted
srcpkgs/python3-tkinter/template:13: build_style must not be quoted
srcpkgs/python3-pyfiglet/template:5: build_style must not be quoted
srcpkgs/python3-poetry-core/template:5: build_style must not be quoted
srcpkgs/python3-neovim/template:5: build_style must not be quoted
srcpkgs/python3-musicbrainzngs/template:5: build_style must not be quoted
srcpkgs/python3-exifread/template:5: build_style must not be quoted
srcpkgs/python3-click/template:5: build_style must not be quoted
srcpkgs/python3-click-threading/template:5: build_style must not be quoted
srcpkgs/python3-click-log/template:5: build_style must not be quoted
srcpkgs/pymol/template:5: build_style must not be quoted
srcpkgs/perl-Locale-PO/template:5: build_style must not be quoted
srcpkgs/peframe/template:5: build_style must not be quoted
srcpkgs/openra/template:5: build_style must not be quoted
srcpkgs/ocs-url/template:6: build_style must not be quoted
srcpkgs/ocaml/template:5: build_style must not be quoted
srcpkgs/net-tools/template:5: build_style must not be quoted
srcpkgs/nasa-wallpaper/template:5: build_style must not be quoted
srcpkgs/mtr/template:5: build_style must not be quoted
srcpkgs/mirage/template:5: build_style must not be quoted
srcpkgs/mawk/template:6: build_style must not be quoted
srcpkgs/lrzip/template:5: build_style must not be quoted
srcpkgs/liquidwar/template:5: build_style must not be quoted
srcpkgs/linphone/template:5: build_style must not be quoted
srcpkgs/lilyterm/template:6: build_style must not be quoted
srcpkgs/lilypond/template:7: build_style must not be quoted
srcpkgs/liboggz/template:5: build_style must not be quoted
srcpkgs/libofx/template:5: build_style must not be quoted
srcpkgs/libfishsound/template:5: build_style must not be quoted
srcpkgs/haskell-language-server/template:5: build_style must not be quoted
srcpkgs/gtklp/template:5: build_style must not be quoted
srcpkgs/grml-rescueboot/template:6: build_style must not be quoted
srcpkgs/git-remote-hg/template:5: build_style must not be quoted
srcpkgs/gerbil/template:5: build_style must not be quoted
srcpkgs/geis/template:5: build_style must not be quoted
srcpkgs/filter_audio/template:9: build_style must not be quoted
srcpkgs/espeakup/template:5: build_style must not be quoted
srcpkgs/chrpath/template:5: build_style must not be quoted
srcpkgs/cc65/template:5: build_style must not be quoted
srcpkgs/blender/template:6: build_style must not be quoted
srcpkgs/ansible/template:5: build_style must not be quoted
srcpkgs/NetAuth/template:5: build_style must not be quoted

@JamiKettunen
Copy link
Contributor Author

pscl on #xbps also added:

Been wondering about the quotes too. I am most surprised by grep -r "distfiles=http" srcpkgs/ - those should be quoted from what I can see.
Similary homepage sometimes has no quotes (but also no variables to expand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant