Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a port pool manager to restrict client ports #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

micoli
Copy link

@micoli micoli commented Sep 30, 2020

this PR to avoid the dynamic attribution of port by net.createServer() but rather by a range specified on the server command line. An internal pool is maintained to distribute ports

@micoli micoli changed the title Add a port manager Add a port pool manager to restrict client ports Oct 1, 2020
@fbricker
Copy link

hi @defunctzombie Merging this will be amazing!

@salemgolemugoo
Copy link

@defunctzombie could you please merge this one? We can configure firewall after that
#143

@defunctzombie
Copy link
Contributor

I don't actively work on this project anymore. @TheBoroer does some upkeep so its up to him.

@iamkhalidbashir
Copy link

this is very important

@MkLHX
Copy link

MkLHX commented Aug 5, 2021

I don't actively work on this project anymore. @TheBoroer does some upkeep so its up to him.

so please say int on front readme to avoid people thinking this project is not dead anymore....

Copy link

@riosje riosje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

@TheBoroer
Copy link

Sorry I've been mia, imma check this out early next week. If its good to go, I'll ping @defunctzombie to give me access to merge it in and push a new version to npm

@dluc
Copy link

dluc commented Mar 13, 2022

Hope to see this feature in soon, it would save from opening a huge amount of ports in the firewall

@luanpontes100
Copy link

I'm using this on my server and something unique happened. I can't say how to recreate this because I'm not able to reproduce myself, but sometimes one URL gives me another client. Let's say I have client1 and client2; sometimes, when I access client1 I'm actually accessing client2, and only normalizes when I restart the server and make the connection again. Do you think this port manager may be the cause?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants