Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(s): OCPP 1.6 configuration manager #286

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xBlaz3kx
Copy link
Contributor

@xBlaz3kx xBlaz3kx commented Aug 1, 2024

Proposed changes

Implemented OCPP 1.6 configuration manager, based on my project.
Features:

  • List of all mandatory and optional OCPP 1.6 configuration keys
  • Mandatory key validation
  • Custom value validation
  • Update observer (triggering a function when a watched key is updated)
  • Storing and retrieving keys and their values

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@xBlaz3kx xBlaz3kx changed the title Implemented OCPP 1.6 configuration manager Feature(s): OCPP 1.6 configuration manager Aug 1, 2024
@andig
Copy link
Contributor

andig commented Sep 6, 2024

It isn't clear to me why this needs be part of this module. If it is for sake of integration capabilities it might be better to add the required APIs here and have the implementation in a separate repo.

@xBlaz3kx
Copy link
Contributor Author

xBlaz3kx commented Sep 6, 2024

It isn't clear to me why this needs be part of this module. If it is for sake of integration capabilities it might be better to add the required APIs here and have the implementation in a separate repo.

Hey @andig,

afaik, it is a part of the roadmap for this repository and I think it would be nice to have everything ocpp related included in one repository.

The configuration manager also adds configuration key validation based on the OCPP profile(s), as each OCPP profile requires some configuration keys to be present (in OCPP specs), which would allow for more standardization and ease of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants