DM-46050: Use average PSF for packaged alerts #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
reviewed
Sep 6, 2024
pipelines/_ingredients/ApPipe.yaml
Outdated
| @@ -72,6 +72,7 @@ tasks: | |||
| config: | |||
| doConfigureApdb: False | |||
| apdb_config_url: parameters.apdb_config | |||
| alertPackager.useAveragePsf: True # Not added to ApPipeWithFakes | |||
There was a problem hiding this comment.
Comment could be a bit clearer; maybe:
Suggested change
| alertPackager.useAveragePsf: True # Not added to ApPipeWithFakes | |
| alertPackager.useAveragePsf: True # Speed up production processing; don't want as default or in ApPipeWithFakes |
isullivan
force-pushed
the
tickets/DM-46050
branch
from
1e34890
to
343cdf2
Compare
Significantly faster than recalculating the PSF at the location of every source, but not as accurate
isullivan
force-pushed
the
tickets/DM-46050
branch
from
343cdf2
to
ead9484
Compare
BrunoSanchez
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly faster than recalculating the PSF at the location of every source, but not as accurate