Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting #2931

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Rate limiting #2931

wants to merge 4 commits into from

Conversation

sajidanower23
Copy link
Contributor

What this PR does

Fixes #1283

Uses the express-rate-limit library to rate limit API requests to the gateway.

Known Issue

It does not use API Keys to rate-limit. To do that, get the API key from the request headers and resolve it to a user within the keyGenerator handler function of the limiter. I could not wrap that function inside a promise, so was not sure how I could use fetch to resolve an API key inside the keyGenerator function.

Checklist

  • There are unit tests to verify my changes are correct Unit tests aren't applicable
  • I've updated CHANGES.md with what I changed.
  • I've linked this PR to an issue in ZenHub (core dev team only)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate Limiting By IP
3 participants