Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow skus with ':'s #3404

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

adamzero1
Copy link

Description (*)

When running bin/magento inventory:reservation:create-compensations if the sku contains ':' the regex breaks, and then the entities can't be loaded.
BEFORE
image
AFTER FIX
image

Fixed Issues (if relevant)

Manual testing scenarios (*)

This is difficult as it requires you to have a reservation inconsistency for a product with a sku with a ';' in it. But if this is the case simply run:
php bin/magento inventory:reservation:create-compensations
(with the compensation string)
You will get error like: "Get EntityId on null"

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant