Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text effect keyboard toolbar for bold, italic, underline and strikethrough formatting #905

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garthvh
Copy link
Member

@garthvh garthvh commented Aug 29, 2024

What changed?

A button and toolbar is going to be added to devices running iOS 18 to allow them to add formatting to their text messages. The text message control on iOS already uses markdown to build the url and phone number links in messages so these already display properly.

Why did it change?

iOS 18 is adding Text Effects which adds a keyboard toolbar item to allow for adding GitHub flavored markdown in messages for bold, italic, strikethrough and underline.

How is this tested?

This is a iOS 18 only feature

Screenshots/Videos (when applicable)

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

@garthvh garthvh added the iOS 18 Stuff required for supporting iOS 18 label Aug 29, 2024
@garthvh garthvh marked this pull request as draft August 29, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS 18 Stuff required for supporting iOS 18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant