Only warn when a message's payloadVariant is unrecognized, rather than error. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed a bit in discord, around the vicinity of https://discord.com/channels/867578229534359593/871553714782081024/1218233913311232041
short version there is that someone was seeing log messages of "ReadFromRadio ❌ Unhandled case 71". 71 is for NeighborInfo packets which the JS doesn't know how to do anything with (which is maybe a separate issue). Upon discussion @ajmcquilkin and I were thinking this seemed more warning-level than error-level.
Hopefully I've switched it to warning correctly, first JS PR obviously!