Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small offering of unit test coverage #595

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

nerdenator
Copy link
Contributor

Increasing unit test line coverage a bit for some of the BLE classes; very very minor code cleanup where I remove a line of code that simply will not be reached.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.38%. Comparing base (d996965) to head (2f812cd).

Files Patch % Lines
meshtastic/ble_interface.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
+ Coverage   58.99%   59.38%   +0.38%     
==========================================
  Files          23       23              
  Lines        3419     3422       +3     
==========================================
+ Hits         2017     2032      +15     
+ Misses       1402     1390      -12     
Flag Coverage Δ
unittests 59.38% <16.66%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianmcorvidae
Copy link
Contributor

It looks like at present this doesn't add any non-commented-out tests -- I'm guessing you're still working on it? If not, let me know.

@nerdenator
Copy link
Contributor Author

@ianmcorvidae Yes, I apologize, been working with other stuff. Basically, I think I need more isolation around the Bluetooth library; it still seems to be calling code that looks for a Bluetooth device on whatever machine is running the unit tests. This won't fail on my machine (which has Bluetooth) but will fail on GitHub Actions' host node, which if I'm guessing, probably doesn't have Bluetooth.

@nerdenator
Copy link
Contributor Author

@ianmcorvidae I think I'm at a stopping point here; there's some details around the Bluetooth connection code that I need to understand better and maybe dig deeper on. I'll try to make draft PRs in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants