-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move module loading out of js::core::Context
, so it can be customised
#6199
Move module loading out of js::core::Context
, so it can be customised
#6199
Conversation
@eddyashton lgtm but deserves a nightly run I think. |
Note for posterity: A previous version of this PR introduced a major memory leak*, that we almost missed as we currently have no visibility into perf regressions. @achamayou stated this explicitly - we're currently making large changes to the JS interpreter but flying blind with regard to the performance impact. We only caught this one pre-merge by chance, because of a single (Daily build-gated) stress test which ballooned the memory so far it crashed a node. Restoring perf visibility is a high priority. * I moved the cache of previously-loaded modules out of the |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Goal is that other apps can use the
js::core::Context
, but read JS code from their own tables. Written to be extensible so they could also load some from hardcoded values, or modify/combine values in the KV, or...