Moving JS registry to public headers #6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achamayou
approved these changes
Jun 3, 2024
|
| Report | Mon, June 3, 2024 at 10:10:11 UTC |
| Project | CCF |
| Branch | 6213/merge |
| Testbed | gha-virtual-ccf-sub |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
- Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) |
|---|---|---|
| commit_latency_ratio | ➖ (view plot) | 0.79 |
| historical_queries | ➖ (view plot) | 63,397.05 |
| pi_basic_js_virtual | ➖ (view plot) | 4,384.00 |
| pi_basic_virtual | ➖ (view plot) | 57,543.90 |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added JS endpoint registry was added in the samples dir, but we recommend subclassing it directly. This moves it to a public header, so it can be used without accessing or copying private/sample headers.
Opening this as a draft while we gather feedback/fixes on the current design, and then we'll cut a further release with this exposed.