-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testType): add support for test.fail.only method #33001
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR needs rebaseline
docs/src/test-api/class-test.md
Outdated
@@ -1096,6 +1096,27 @@ test('less readable', async ({ page }) => { | |||
}); | |||
``` | |||
|
|||
You can use `test.fail.only` to focus on a specific test that is expected to fail. This is particularly useful when debugging a failing test or working on a specific issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this section - I would omit this as implied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Removed! :)
docs/src/test-sharding-js.md
Outdated
@@ -26,6 +26,25 @@ Now, if you run these shards in parallel on different jobs, your test suite comp | |||
|
|||
Note that Playwright can only shard tests that can be run in parallel. By default, this means Playwright will shard test files. Learn about other options in the [parallelism guide](./test-parallel.md). | |||
|
|||
|
|||
## Balancing Shards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like you need a rebaseline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase applied, thanks for the feedback. :)
a13163d
to
88866a0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e22847e
to
dbaf553
Compare
Test results for "tests 1"10 failed 2 flaky35900 passed, 620 skipped Merge workflow run. |
Description
Following up on issue #30662
This PR adds support for
test.fail.only
in Playwright Test, allowing developers to focus on a specific test that is expected to fail.As this is my first contribution, I would appreciate feedback on the regression tests and documentation updates. If there are any changes needed, I'm happy to make them. :)