Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): bring back the headed param #33030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): bring back the headed param #33030

wants to merge 1 commit into from
+5 −4

Conversation

pavelfeldman
Copy link
Member

Fixes #33023

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Test results for "tests 1"

155 failed
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:21:5 › should contain text attachment @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:61:5 › should contain binary attachment @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:81:5 › should contain string attachment @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:102:5 › should linkify string attachments @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:19:5 › should filter network requests by resource type @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:61:5 › should filter network requests by url @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:97:5 › should format JSON request body @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:139:5 › should display list of query parameters (only if present) @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:117:5 › should format console messages in page @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:159:5 › should stream console messages live @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:186:5 › should print beforeAll console messages once @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:115:5 › should preserve action list selection upon live trace update @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:216:5 › should show trace w/ multiple contexts @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:248:5 › should show live trace for serial @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:292:5 › should show live trace from hooks @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-update.spec.ts:132:5 › should not loose run information after execution if test wrote into testDir @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:51:5 › should merge web assertion events @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:104:5 › should locate sync assertions in source @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:123:5 › should show snapshots for sync assertions @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:155:5 › should show image diff @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:180:5 › should show screenshot @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:203:5 › should not fail on internal page logs @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:232:5 › should not show caught errors in the errors tab @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:264:5 › should reveal errors in the sourcetab @macos-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:290:5 › should show request source context id @macos-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:21:5 › should contain text attachment @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:61:5 › should contain binary attachment @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:81:5 › should contain string attachment @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:102:5 › should linkify string attachments @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:19:5 › should filter network requests by resource type @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:61:5 › should filter network requests by url @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:97:5 › should format JSON request body @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:139:5 › should display list of query parameters (only if present) @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:117:5 › should format console messages in page @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:159:5 › should stream console messages live @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:186:5 › should print beforeAll console messages once @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:115:5 › should preserve action list selection upon live trace update @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:216:5 › should show trace w/ multiple contexts @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:248:5 › should show live trace for serial @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:292:5 › should show live trace from hooks @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-update.spec.ts:132:5 › should not loose run information after execution if test wrote into testDir @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:51:5 › should merge web assertion events @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:104:5 › should locate sync assertions in source @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:123:5 › should show snapshots for sync assertions @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:155:5 › should show image diff @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:180:5 › should show screenshot @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:203:5 › should not fail on internal page logs @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:232:5 › should not show caught errors in the errors tab @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:264:5 › should reveal errors in the sourcetab @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:290:5 › should show request source context id @ubuntu-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:21:5 › should contain text attachment @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:61:5 › should contain binary attachment @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:81:5 › should contain string attachment @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:102:5 › should linkify string attachments @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:19:5 › should filter network requests by resource type @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:61:5 › should filter network requests by url @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:97:5 › should format JSON request body @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:139:5 › should display list of query parameters (only if present) @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:117:5 › should format console messages in page @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:159:5 › should stream console messages live @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:186:5 › should print beforeAll console messages once @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:115:5 › should preserve action list selection upon live trace update @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:216:5 › should show trace w/ multiple contexts @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:248:5 › should show live trace for serial @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:292:5 › should show live trace from hooks @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-update.spec.ts:132:5 › should not loose run information after execution if test wrote into testDir @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:51:5 › should merge web assertion events @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:104:5 › should locate sync assertions in source @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:123:5 › should show snapshots for sync assertions @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:155:5 › should show image diff @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:180:5 › should show screenshot @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:203:5 › should not fail on internal page logs @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:232:5 › should not show caught errors in the errors tab @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:264:5 › should reveal errors in the sourcetab @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-trace.spec.ts:290:5 › should show request source context id @ubuntu-latest-node20-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:21:5 › should contain text attachment @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:61:5 › should contain binary attachment @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:81:5 › should contain string attachment @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:102:5 › should linkify string attachments @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:19:5 › should filter network requests by resource type @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:61:5 › should filter network requests by url @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:97:5 › should format JSON request body @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:139:5 › should display list of query parameters (only if present) @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:117:5 › should format console messages in page @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:159:5 › should stream console messages live @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:186:5 › should print beforeAll console messages once @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:115:5 › should preserve action list selection upon live trace update @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:216:5 › should show trace w/ multiple contexts @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:248:5 › should show live trace for serial @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:292:5 › should show live trace from hooks @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-update.spec.ts:132:5 › should not loose run information after execution if test wrote into testDir @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:51:5 › should merge web assertion events @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:104:5 › should locate sync assertions in source @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:123:5 › should show snapshots for sync assertions @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:155:5 › should show image diff @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:180:5 › should show screenshot @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:203:5 › should not fail on internal page logs @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:232:5 › should not show caught errors in the errors tab @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:264:5 › should reveal errors in the sourcetab @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-trace.spec.ts:290:5 › should show request source context id @ubuntu-latest-node22-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:21:5 › should contain text attachment @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:61:5 › should contain binary attachment @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:81:5 › should contain string attachment @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-attachments.spec.ts:102:5 › should linkify string attachments @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:19:5 › should filter network requests by resource type @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:61:5 › should filter network requests by url @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:97:5 › should format JSON request body @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:139:5 › should display list of query parameters (only if present) @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:117:5 › should format console messages in page @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:159:5 › should stream console messages live @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-output.spec.ts:186:5 › should print beforeAll console messages once @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:115:5 › should preserve action list selection upon live trace update @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:216:5 › should show trace w/ multiple contexts @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:248:5 › should show live trace for serial @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-progress.spec.ts:292:5 › should show live trace from hooks @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots @windows-latest-node18-1
❌ [playwright-test] › ui-mode-test-update.spec.ts:132:5 › should not loose run information after execution if test wrote into testDir @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:22:5 › should merge trace events @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:51:5 › should merge web assertion events @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:76:5 › should merge screenshot assertions @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:104:5 › should locate sync assertions in source @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:123:5 › should show snapshots for sync assertions @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:155:5 › should show image diff @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:180:5 › should show screenshot @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:203:5 › should not fail on internal page logs @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:232:5 › should not show caught errors in the errors tab @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:264:5 › should reveal errors in the sourcetab @windows-latest-node18-1
❌ [playwright-test] › ui-mode-trace.spec.ts:290:5 › should show request source context id @windows-latest-node18-1

35717 passed, 620 skipped
✔️✔️✔️

Merge workflow run.

yury-s
yury-s reviewed Oct 9, 2024
View reviewed changes
packages/playwright/src/runner/testServer.ts
video: params.video === 'on' ? 'on' : (params.video === 'off' ? 'off' : undefined),
headless: params.headed ? false : undefined,
...this._configCLIOverrides.use,
...(params.trace === 'on' ? { mode: 'on', sources: false, _live: true } : {}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
...(params.trace === 'on' ? { mode: 'on', sources: false, _live: true } : {}),
...(params.trace === 'on' ? { trace: { mode: 'on', sources: false, _live: true }} : {}),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: command line flag --headed has no effect in ui mode
3 participants
@pavelfeldman @yury-s @dgozman