Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sese] update usage #41407

Merged
merged 3 commits into from
Oct 8, 2024
Merged

[sese] update usage #41407

merged 3 commits into from
Oct 8, 2024

Conversation

SHIINASAMA
Copy link
Contributor

@SHIINASAMA SHIINASAMA commented Oct 8, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Updated the post-version because I noticed that I forgot to update the usage file.

It was my carelessness, and I'm sorry.

@dg0yt
Copy link
Contributor

dg0yt commented Oct 8, 2024

It was my carelessness, and I'm sorry.

No, it was merged carelessly. Please consider the review comments in #41402.

@SHIINASAMA
Copy link
Contributor Author

@dg0yt Thanks for your reviews. Maybe the previous test was not accurate, it really did not have a pdb file at the time, but it has been resolved now and this patch is not necessary.

ports/sese/usage Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 8, 2024
@LilyWangLL LilyWangLL marked this pull request as draft October 8, 2024 08:49
@LilyWangLL
Copy link
Contributor

Usage passed on x64-windows.

@LilyWangLL LilyWangLL marked this pull request as ready for review October 8, 2024 09:48
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 8, 2024
@JavierMatosD
Copy link
Contributor

It was my carelessness, and I'm sorry.

It was my mistake! Thank you for the contribution!

@JavierMatosD JavierMatosD merged commit 2951b6e into microsoft:master Oct 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants