Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add array json #127

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Add array json #127

merged 1 commit into from
Apr 14, 2023

Conversation

jiaoew1991
Copy link
Contributor

No description provided.

@jiaoew1991 jiaoew1991 marked this pull request as draft April 13, 2023 06:33
@sre-ci-robot sre-ci-robot added do-not-merge/work-in-progress Don't merge even CI passed. size/L labels Apr 13, 2023
@mergify mergify bot added needs-dco DCO is missing in this pull request. do-not-merge/missing-related-issue labels Apr 13, 2023
@mergify
Copy link

mergify bot commented Apr 13, 2023

@jiaoew1991 Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

@mergify mergify bot added the ci-passed label Apr 13, 2023
@jiaoew1991
Add array and json support
15df14e 
Signed-off-by: Enwei Jiao <[email protected]>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 13, 2023
@jiaoew1991 jiaoew1991 marked this pull request as ready for review April 13, 2023 10:43
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Apr 13, 2023
@jiaoew1991
Copy link
Contributor Author

issue: milvus-io/milvus#23389

@jiaoew1991
Copy link
Contributor Author

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Apr 13, 2023
@jiaoew1991
Copy link
Contributor Author

issue: #128

@mergify mergify bot added ci-passed and removed ci-passed labels Apr 13, 2023
xiaofan-luan
xiaofan-luan reviewed Apr 13, 2023
View reviewed changes
proto/schema.proto
@@ -103,6 +97,8 @@ message ScalarField {
DoubleArray double_data = 5;
StringArray string_data = 6;
BytesArray bytes_data = 7;
ArrayArray array_data = 8;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not work the Array of Array and JSON Array since that would be too much?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arrays of other databases only support a single type, and a single-type array can be optimized for more operations. In addition, JSON arrays can be represented using the JSON data type.

@yhmo
Copy link
Collaborator

yhmo commented Apr 14, 2023

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 06be538 into milvus-io:master Apr 14, 2023
yah01 pushed a commit to yah01/milvus-proto that referenced this pull request May 3, 2023
@jiaoew1991 @yah01
Add array and json support (milvus-io#127)
a24c3de 
Signed-off-by: Enwei Jiao <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request May 4, 2023
@yah01 @jiaoew1991
Add array and json support (#127) (#140)
680903b 
Signed-off-by: Enwei Jiao <[email protected]>
Co-authored-by: Enwei Jiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@nameczz nameczz Awaiting requested review from nameczz

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@yhmo yhmo

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiaoew1991 @yhmo @sre-ci-robot @xiaofan-luan