Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Huggingface Integration #916
base: master
Are you sure you want to change the base?
Add Huggingface Integration #916
Changes from all commits
56dacad
32a206e
f8c3e6a
4651320
5a8a7f1
350906f
26bdd11
178b5ab
0e6a297
97585b8
99d91bd
3fdf152
9c414d9
2c70b01
57f22fc
8ac070a
c4fc455
be4a3c9
0d6b998
5511c17
4c3804f
f51d7a4
8a7ad4c
acd6bdf
38984d0
912b7f8
a7f6335
06564b5
7ac6b94
a955473
1a9d6e9
5e8a97b
a0c7e2d
5e9374b
8c788ee
202230a
d82e473
3cadbfd
04e049c
be3c37f
805bc06
8cd0d7d
b925855
d0e412f
cb9c4c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above about
template_str
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this alias is really needed. I would simply call
snapshot_download
in other places in the code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think the alias is not needed and that
snapshot_download
could be used by defaultThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wauplin actually this alias is use for the alignment of hugging face downloading feature with Gandlf command line design pattern ,change it to by default may abruptly conflict the command line argument