-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move double
method to func in math
#1050
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
From the provided
These suggestions aim to improve code readability, reduce redundancy, and ensure consistency across the codebase. |
Pull Request Test Coverage Report for Build 3338Details
💛 - Coveralls |
318e716
to
7baf756
Compare
the CI failure looks weird |
Because See: Line 132 in 7baf756
|
I think it's better to make As there may be
|
Please make sure to update NOTICE file to include updated path for the |
This may or may not be in the scope of this PR, but for consistency, math functions in |
7bdac9c
to
86310f8
Compare
86310f8
to
ebca879
Compare
Unfortunately unless we bring back |
IMO adding
|
This pull request focuses on deprecating several mathematical functions in the
Double
type and moving their implementations to themath
module. Key changes include marking functions as deprecated, adding new implementations, and updating tests accordingly.Deprecation and Implementation Changes:
double/double.mbti
: Markedexp
,log10
,log2
,min_normal
, andnan
as deprecated. [1] [2]double/exp_js.mbt
anddouble/exp_nonjs.mbt
: Added deprecation alerts forexp
and provided new implementations. [1] [2]double/log.mbt
: Commented out deprecation forln
and added deprecation alerts forlog2
andlog10
. [1] [2] [3]New Implementations in
math
Module:math/exp_js.mbt
andmath/exp_nonjs.mbt
: Added new implementations forexp
function. [1] [2]math/log.mbt
: Added new implementations forln
,log2
, andlog10
functions.Test Updates:
double/exp_test.mbt
: Removed old tests forexp
,log2
,log10
, andln
. [1] [2]math/exp_test.mbt
: Added new tests forexp
, including special values and overflow/underflow cases.math/log.mbt
: Added new tests forlog2
,log10
, andln
.Other Changes:
math/math.mbti
: Added function signatures forexp
,ln
,log10
, andlog2
.math/moon.pkg.json
: Updated package configuration to include new targets forexp_js.mbt
andexp_nonjs.mbt
.Some problems encounterd
double::ln
is used bylog2
andlog10
, so a deprecation notice will persist since we also want to deprecateln
sqrt
is implemented as method (and overloaded to support bothfloat
anddouble
) and function argument cannot be overloaded, so it's not possible to migrate this.close #1046