bring back optional field test

[bobzhang]

No description provided.

[peter-jerry-ye-code-review]

Observations and Suggestions

1. Typo in Test Name:

   • In the json/to_json_test.mbt file, there is a commented-out test block with a typo in the test name. The correct term should be "optional" instead of "optinal".
   • Suggestion: Correct the typo in the test name and uncomment the test block to ensure it runs as expected.

2. Incorrect Data Type Conversion:

   • In several functions within the bool/bool.mbt file, there are instances where the conversion from Bool to Int64, UInt, and UInt64 uses incorrect suffixes (L, U, UL). In MoonBit, these suffixes are not used; instead, the literals should be directly assigned.
   • Suggestion: Update the literals to remove the incorrect suffixes, e.g., change 1L to 1, 1U to 1, and 1UL to 1.

3. Inconsistent JSON Representation:

   • In the builtin/json.mbt file, the Bool::to_json function converts Bool values to Json using True and False. However, in MoonBit, the correct constants for boolean JSON values are true and false.
   • Suggestion: Update the Bool::to_json function to use true and false instead of True and False.

These observations focus on potential bugs and inconsistencies that could affect the correctness and readability of the code. Addressing these issues will help ensure that the code is both functional and adherent to MoonBit's syntax and conventions.

[coveralls]

Pull Request Test Coverage Report for Build 3335

Details

• 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 83.283%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
builtin/json.mbt	0	2	0.0%

Totals
Change from base Build 3330:	0.0%
Covered Lines:	4100
Relevant Lines:	4923

---

💛 - Coveralls