Fix: make optional chaining expression work #1684
Open
+134
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e. code such as:
```js
o = {a: true};
o?.['a']
```
Note that the spec says that the expression on the right-hand side
should _not_ be evaluated if the left-hand side object is null or
undefined.
andreabergia
force-pushed
the
optional-chaining-expressions-2
branch
from
28c7c84
to
52a1ce2
Compare
|
Great! |
|
I guess you're saying that the previously merged optional chaining operator support didn't properly supported computed properties? Wrt to your 'note': think you filled #1600 for that already, no? |
It didn't support them at all - it didn't even parse the syntax 🙂
Yeah, but I have done something smaller in scope in this PR: I've just made this new implementation work correctly per the spec. I haven't fixed the general problem because, honestly, I can't imagine how to do it without having a big performance impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. makes this work:
Note that the spec says that the expression on the right-hand side should not be evaluated if the left-hand side object is null or undefined.
Follow-up from #1593