Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mui-material][Select] Add native-like behavior for select #43871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulsohn
Copy link

@paulsohn paulsohn commented Sep 24, 2024

implements #43813 .

@mui-bot
Copy link

mui-bot commented Sep 24, 2024

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against f0611dc

@zannager zannager added the component: select This is the name of the generic UI component, not the React module! label Sep 24, 2024
@paulsohn
Copy link
Author

paulsohn commented Sep 25, 2024

One note is that it does not support mobile devices (which obviously do not have ctrl key) currently.
I added this nativeLike option just for desktop applications, which is my intended use case, so I'm not sure what should we do for mobile support.

* Only applicable when `multiple` is `true` and `native` is `false`.
* @default false
*/
nativeLike: PropTypes.bool,
Copy link
Member

@mnajdova mnajdova Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we plan to land this feature we need to come up with a better name for the prop, is too close to the native prop, and works when the native prop is false. btw @atomiks do we have this feature planned for the Base UI select?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-select is planned for later

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atomiks how much later? Asking so we can plan the Select refactor accordingly.

As for this feature, we should only implement it if we're sure that Base UI will eventually implement it. Otherwise, we would support it, only for it to change in the upcoming major version which is built on top of Base UI.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants