Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Add pointer cursor on hover for logo to improve UX #43999

Merged
merged 8 commits into from
Oct 8, 2024
Merged

[docs-infra] Add pointer cursor on hover for logo to improve UX #43999

merged 8 commits into from
Oct 8, 2024

Conversation

Asin-Junior-Honore
Copy link
Contributor

@Asin-Junior-Honore Asin-Junior-Honore commented Oct 5, 2024 •
edited by oliviertassinari
Loading

fix: add pointer cursor on hover for logo to improve UX

Closes #43998

@Asin-Junior-Honore
Update LogoWithCopyMenu.tsx
7a05eee 
fix: add pointer cursor on hover for logo to improve UX


Signed-off-by:  Asin-Junior-Honore <[email protected]>
@mui-bot
Copy link

mui-bot commented Oct 5, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43999--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 678d1d2

@Asin-Junior-Honore Asin-Junior-Honore changed the title Update LogoWithCopyMenu.tsx [docs]: Add pointer cursor on hover for logo to improve UX Oct 5, 2024
@Asin-Junior-Honore Asin-Junior-Honore changed the title [docs]: Add pointer cursor on hover for logo to improve UX [docs]: Add pointer cursor on hover for logo to improve UX Oct 5, 2024
@Asin-Junior-Honore
Update LogoWithCopyMenu.tsx
6b2364f 
Signed-off-by:  Asin-Junior-Honore <[email protected]>
@Asin-Junior-Honore Asin-Junior-Honore mentioned this pull request Oct 5, 2024
Closed
@oliviertassinari oliviertassinari changed the title [docs]: Add pointer cursor on hover for logo to improve UX [docs] Add pointer cursor on hover for logo to improve UX Oct 5, 2024
@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Oct 5, 2024
@oliviertassinari oliviertassinari changed the title [docs] Add pointer cursor on hover for logo to improve UX [docs-infra] Add pointer cursor on hover for logo to improve UX Oct 5, 2024
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer labels Oct 5, 2024
@Asin-Junior-Honore
Copy link
Contributor Author

Hello @oliviertassinari, I hope you're doing well. I wanted to kindly follow up on my PR and see if there are any updates. Thank you so much for your time! 🙏

KirankumarAmbati
KirankumarAmbati approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@KirankumarAmbati KirankumarAmbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not the official reviewer but the change is looking good. (Verified the preview as well)

mnajdova
mnajdova approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first pull request on MUI 👌 Thank you for working on it!

@mnajdova mnajdova merged commit 0b51586 into mui:master Oct 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@KirankumarAmbati KirankumarAmbati KirankumarAmbati approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Logo does not display pointer cursor on hover for better UX
5 participants
@Asin-Junior-Honore @mui-bot @oliviertassinari @mnajdova @KirankumarAmbati