fix: sticky chapter on mouseout #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
- Coverage 78.55% 76.94% -1.62%
==========================================
Files 59 50 -9
Lines 11080 12093 +1013
Branches 0 699 +699
==========================================
+ Hits 8704 9305 +601
- Misses 2376 2762 +386
- Partials 0 26 +26 ☔ View full report in Codecov by Sentry. |
cjpillsbury
reviewed
Oct 8, 2024
| @@ -388,6 +387,10 @@ class MediaChromeRange extends globalThis.HTMLElement { | |||
| this.#cssRules.pointer = getOrInsertCSSRule(this.shadowRoot, '#pointer'); | |||
| this.#cssRules.progress = getOrInsertCSSRule(this.shadowRoot, '#progress'); | |||
| this.#cssRules.thumb = getOrInsertCSSRule(this.shadowRoot, '#thumb'); | |||
| this.#cssRules.activeSegment = getOrInsertCSSRule( | |||
cjpillsbury
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #999
I can't reproduce it anymore so hopefully fixed.
the bug happened when
updateSegmentswas called multiple times, easier to reproduce with preload none.insertCSSRulecreated a rule every timeupdateSegmentswas called so it possibly happened while the user hovered over a chapter.