Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove example themes #961

Merged
merged 5 commits into from
Aug 16, 2024
Merged

feat: remove example themes #961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9f67ab7
fix: remove example themes
luwes Aug 16, 2024
52a7485
docs: add migration note of themes removal
luwes Aug 16, 2024
0d0dfe4
docs: fix TW audio theme url
luwes Aug 16, 2024
b5daa64
docs: remove Netflix, Spotify example
luwes Aug 16, 2024
0bbd0a2
docs: remove themes from docs examples
luwes Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 41 additions & 56 deletions docs/src/pages/docs/en/examples/[...example].astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,62 +95,47 @@ export function getStaticPaths({ paginate }: GetStaticPathsOptions) {
sourcePath: 'examples/vanilla/control-elements/media-playback-rate-menu.html',
}
},
{
params: { example: 'tailwind-audio-theme' },
props: {
title: 'Tailwind Audio Theme',
group: 'Themes',
sourcePath: 'examples/vanilla/themes/tailwind-audio-theme/index.html',
}
},
{
params: { example: 'minimal-theme' },
props: {
title: 'Minimal Theme',
group: 'Themes',
sourcePath: 'examples/vanilla/themes/minimal-theme.html',
}
},
{
params: { example: 'microvideo-theme' },
props: {
title: 'Microvideo Theme',
group: 'Themes',
sourcePath: 'examples/vanilla/themes/microvideo-theme.html',
}
},
{
params: { example: 'demuxed-2022-theme' },
props: {
title: 'Demuxed 2022 Theme',
group: 'Themes',
sourcePath: 'examples/vanilla/themes/demuxed-2022-theme.html',
}
},
{
params: { example: 'youtube-theme' },
props: {
title: 'Youtube Theme',
group: 'Themes',
sourcePath: 'examples/vanilla/themes/youtube-theme.html',
}
},
{
params: { example: 'netflix-theme' },
props: {
title: 'Netflix Theme',
group: 'Themes',
sourcePath: 'examples/vanilla/themes/netflix-theme.html',
}
},
{
params: { example: 'spotify-theme' },
props: {
title: 'Spotify Theme',
group: 'Themes',
sourcePath: 'examples/vanilla/themes/spotify-theme.html',
}
},
// Remove themes from examples. todo: fix `media-chrome` dependency.
// {
// params: { example: 'tailwind-audio-theme' },
// props: {
// title: 'Tailwind Audio Theme',
// group: 'Themes',
// sourcePath: 'examples/vanilla/themes/tailwind-audio-theme.html',
// }
// },
// {
// params: { example: 'minimal-theme' },
// props: {
// title: 'Minimal Theme',
// group: 'Themes',
// sourcePath: 'examples/vanilla/themes/minimal-theme.html',
// }
// },
// {
// params: { example: 'microvideo-theme' },
// props: {
// title: 'Microvideo Theme',
// group: 'Themes',
// sourcePath: 'examples/vanilla/themes/microvideo-theme.html',
// }
// },
// {
// params: { example: 'demuxed-2022-theme' },
// props: {
// title: 'Demuxed 2022 Theme',
// group: 'Themes',
// sourcePath: 'examples/vanilla/themes/demuxed-2022-theme.html',
// }
// },
// {
// params: { example: 'youtube-theme' },
// props: {
// title: 'Youtube Theme',
// group: 'Themes',
// sourcePath: 'examples/vanilla/themes/youtube-theme.html',
// }
// },
]
}

Expand Down
2 changes: 2 additions & 0 deletions docs/src/pages/docs/en/migration/from-3.x-to-4.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Here's a high level overview:
**Menu components moved to separate import**
- The menu components that were included by default in v3 are now moved to a separate import. This gives you more granular control and can save some extra weight in the final JS bundle if you don't need these components. You can import them from `media-chrome/menu`.

**Example themes are removed from the package**
- The example themes are removed from the package (dist/themes/\*), but not to worry, most themes will live on in https://player.style!

### Example of HTML changes

Expand Down
6 changes: 1 addition & 5 deletions examples/vanilla/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,11 @@ <h2>Media element examples</h2>

<h2>Example themes</h2>
<ul>
<li><a href="themes/tailwind-audio-theme/">Tailwind Audio Theme</a></li>
<li><a href="themes/tailwind-audio-theme.html">Tailwind Audio Theme</a></li>
<li><a href="themes/minimal-theme.html">Minimal Theme</a></li>
<li><a href="themes/microvideo-theme.html">Microvideo Theme</a></li>
<li><a href="themes/youtube-theme.html">Youtube Theme</a></li>
<li><a href="themes/netflix-theme.html">Netflix Theme</a></li>
<li><a href="themes/spotify-theme.html">Spotify Theme</a></li>
<li><a href="themes/responsive-theme.html">Responsive Theme</a></li>
<li><a href="themes/winamp-theme.html">Winamp Theme</a></li>
<li><a href="themes/demuxed-2021-theme.html">Demuxed 2021 Theme</a></li>
<li><a href="themes/demuxed-2022-theme.html">Demuxed 2022 Theme</a></li>
</ul>

Expand Down
654 changes: 0 additions & 654 deletions examples/vanilla/themes/demuxed-2021-theme.html
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion examples/vanilla/themes/demuxed-2022-theme.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta name="viewport" content="width=device-width" />
<title>Media Chrome Demuxed 2022 Theme Example</title>
<script type="module" src="../../../dist/index.js"></script>
<script type="module" src="../../../dist/themes/demuxed-2022.js"></script>
<script type="module" src="https://cdn.jsdelivr.net/npm/@player.style/demuxed-2022/+esm"></script>
<script defer src="https://www.gstatic.com/cv/js/sender/v1/cast_sender.js?loadCastFramework=1"></script>
<script type="module" src="https://cdn.jsdelivr.net/npm/castable-video@1/+esm"></script>
<link rel="stylesheet" href="https://use.typekit.net/dbt1sbf.css">
Expand Down
2 changes: 1 addition & 1 deletion examples/vanilla/themes/microvideo-theme.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>Media Chrome - Microvideo Theme</title>

<script type="module" src="../../../dist/index.js"></script>
<script type="module" src="../../../dist/themes/microvideo.js"></script>
<script type="module" src="https://cdn.jsdelivr.net/npm/@player.style/microvideo/+esm"></script>

<style>
body {
Expand Down
2 changes: 1 addition & 1 deletion examples/vanilla/themes/minimal-theme.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/>
<script type="module" src="https://cdn.jsdelivr.net/npm/@mux/mux-video"></script>
<script type="module" src="../../../dist/index.js"></script>
<script type="module" src="../../../dist/themes/minimal.js"></script>
<script type="module" src="https://cdn.jsdelivr.net/npm/@player.style/minimal/+esm"></script>

<style>
html {
Expand Down
43 changes: 0 additions & 43 deletions examples/vanilla/themes/netflix-theme.html
View file
Open in desktop

This file was deleted.

74 changes: 0 additions & 74 deletions examples/vanilla/themes/responsive-theme.html
View file
Open in desktop

This file was deleted.

Loading
Loading