Feature/ros2 rust #316
Merged
Feature/ros2 rust #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdelfin PTAL and lemme know if you know anything about bazelbuild/rules_rust#2650. Thanks in advance. |
mvukov
force-pushed
the
feature/ros2_rust
branch
2 times, most recently
from
c43cc45
to
1a26c04
Compare
|
Regarding the CI failures: bazelbuild/rules_rust#2662. |
… feature/ros2_rust
|
Hey @mvukov sorry for the delay. Looking for someone on our team who can look at this as I'll be leaving wayve |
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Jul 13, 2024
In my repo mvukov/rules_ros2#316 I have a use-case that I want to pass some cc-deps via dep_variant_info as in https://github.com/mvukov/rules_ros2/pull/316/files#diff-58917867447a8263989afcfff01c87ad154b41562efc3f6d789807efb26e298fR231-R253. This PR enables that.
github-merge-queue bot
pushed a commit
to bazelbuild/rules_rust
that referenced
this pull request
Jul 18, 2024
In my repo mvukov/rules_ros2#316 I have a use-case that I want to pass some cc-deps via dep_variant_info as in https://github.com/mvukov/rules_ros2/pull/316/files#diff-58917867447a8263989afcfff01c87ad154b41562efc3f6d789807efb26e298fR231-R253. This PR enables that.
parth-emancro
pushed a commit
to emancro/rules_ros2
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Milan Vukov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose to hook ros2_rust over r2r, mainly because handling IDL bindings is streamlined with handling of C/C++/Python IDL bindings. The one in r2r looks very hacky and not scalable. On the other hand r2r is more feature-rich at the moment, but I expect that to change.
Issues found along the way: