Skip to content
This repository has been archived by the owner on Nov 8, 2021. It is now read-only.

Use relative path so that we properly apply --base-href. #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SamuelMS
Copy link

@SamuelMS SamuelMS commented Oct 16, 2018

Re-implements changes from #12, since they were backed out due to failing tests.

@ocombe Would you mind reviewing when you get a moment? Thanks!

@sergio-new-developer
Copy link

sergio-new-developer commented Oct 28, 2018

I have the same problem..

@MickL
Copy link

MickL commented May 15, 2019

I just wanted to make the exact same pull-request. You might add changes to README.md, too. Nearly one year later, why is it not merged?

There is no reason for having a hardcoded path.

@MickL
Copy link

MickL commented May 15, 2019

@ocombe please accept

Copy link

@markstein markstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a mandatory change for relative context paths

tonio added a commit to geonetwork/geonetwork-ui that referenced this pull request Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants