lib/options: refactor and rename (non-breaking) #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`freeformModule { foo = mkOption {}; }` is equivalent to:
```nix
submodule {
freeformType = attrsOf anything;
options = { foo = mkOption {}; };
}
```
Helper functions to create non-null options that support the raw type.
Where applicable, top-level helper functions are moved into the new attrset `nullableOpts`.
The base `mkNullOrLua'` function can just check if `type` is provided.
We should first look for all the occurences in the code base and then, if none of this use cases is legit, we should remove it. |
MattSturgeon
changed the title
MattSturgeon
changed the title
|
Although your description is very clear, I would prefer if this set of changes is spread accross a few individual PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/types: add
nixvimTypes.freeformModuleWe often have submodules in
settingsoptions, most of these should be freeform although many aren't.lib/options: add
rawOptshelpersNew helpers for making non-null options that support the raw type.
lib/options: move top-level helpers to
nullableOptsMost of the top-level option helpers were actually creating nullable options. Move them into their own scope.
lib/options: standardise raw-type support in
defaultNullOptsmkAttrsOf(etc) didn't injectmaybeRaweverywhere they should. Also begin transitioningmkNullableandmkNullableWithRawby introducingmkNullableNoRawalias.lib/options: merge
mkNullOrStrLuaOr'(etc)This is the only breaking change, although I don't think anyone ever used these.
Other
Do we still need
mkCompositeOption? Should we make it freeform?