modules/performance: add byteCompileLua option #1887
Conversation
stasjok
force-pushed
the
byte-compile-lua-pr
branch
from
ea63a1c
to
a16b7e0
Compare
|
It looks like a lot of code that I traced to find any parts generating config files would be changed by #1889. Only three last commits beginning with "modules/performance: add byteCompileLua option" is related to this PR, but it'll definitely will conflict (as is the second my PR). So I guess I'll have to re-implement things. |
stasjok
force-pushed
the
byte-compile-lua-pr
branch
from
a16b7e0
to
45b775c
Compare
stasjok
force-pushed
the
byte-compile-lua-pr
branch
2 times, most recently
from
9cd6533
to
3caca7c
Compare
|
Rebased and changed implementation for byte compiling extraFiles. Other implementations stayed as it was (in particularly init.lua). I hope this time it's alright, because it'll be frustrating if it needs to be rewritten again. |
Looks like it only affects Darwin |
stasjok
force-pushed
the
byte-compile-lua-pr
branch
2 times, most recently
from
0bae1ff
to
0ba8d21
Compare
There was a problem hiding this comment.
Sorry for the late review.
I had an overall look at the PR and trust @MattSturgeon and @traxys for checking the details.
Thank you very much @stasjok for this amazing work. Also the effort you have put in documentation and testing is truly appreciable !
|
Will it get merged? |
|
Sure ! Let's give this a shot. Thanks for the hard work ! @Mergifyio queue |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
GaetanLepage
force-pushed
the
byte-compile-lua-pr
branch
from
0ba8d21
to
aa57d59
Compare
|
(I'm going to re-queue this so it merges after #1956, since that PR doesn't need rebasing) |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 9314cd4 |
* add `performance.byteCompileLua.enable` toggle to enable or disable all byte compiling features * add `performance.byteCompileLua.initLua` toggle to enable or disable byte compiling of init.lua * add `writeByteCompiledLua` helper for saving byte compiled lua source code to the nix store * `nixvim-print-init` utility is always pointed to uncompiled init.lua * add tests
This commit adds support for byte compiling lua configuration files. It's enabled by default (if byte compiling is enabled at all) and can be disabled with `performance.byteCompileLua.configs` toggle. To implement this feature `extraFiles.<name>.finalSource` internal read-only option is introduced. `source` option cannot be used because it's user configurable. In order to access the values of the `performance.byteCompileLua` options, parent config is added to specialArgs of extraFiles submodule. Then the usages of `source` option changed to `finalSource` in all relevant places (filesPlugin and wrappers). Added more helpers for various cases of byte compiling: * `byteCompileLuaFile` byte compiles lua file * `byteCompileLuaHook` is a setup hook that byte compiles all lua files * `byteCompileLuaDrv` overrides derivation by adding byteCompileLuaHook to it Added tests to validate that extraFiles specified by various methods are handled correctly. Added a separate home-manager test, that is intended to validate that extraFiles propagated to wrapper modules are correctly byte compiled.
This commit adds `performance.byteCompileLua.plugins` toggle that, if enabled, byte compiles all lua files in plugins
This commit adds `performance.byteCompileLua.nvimRuntime` toggle that, if enabled, byte compiles all lua files in Nvim runtime directory.
GaetanLepage
force-pushed
the
byte-compile-lua-pr
branch
from
aa57d59
to
9314cd4
Compare
|
@stasjok thanks again for all your hard work, persistence and dedication! |
This PR implements a second item from this comment.
It can be merged only on top of #1886.
It introduces an option
performance.byteCompileLua, that, when enabled, byte compiles lua files. It can be configured what to compile. By default it's user configs. But also plugins and neovim itself can be compiled.