plugins/lsp: Auto generate the list of lsp servers #2365
Conversation
traxys
force-pushed
the
all-lsp-servers
branch
6 times, most recently
from
860e331
to
a1cb585
Compare
This test is quite resource intensive, so let's split it to avoid issues
traxys
force-pushed
the
all-lsp-servers
branch
4 times, most recently
from
d05afe4
to
c90930c
Compare
|
This solves: #2335 |
| @@ -0,0 +1,3 @@ | |||
| function Header(elem) | |||
| return pandoc.Strong(elem.content) | |||
| end | |||
There was a problem hiding this comment.
Wish inline lua in python didn't require an additional dependency...
| info = sorted_map_table(configs, function(server_name, server_info) | ||
| local description = nil | ||
| if server_info.document_config.docs ~= nil then | ||
| description = server_info.document_config.docs.description |
There was a problem hiding this comment.
Do they provide any other metadata? Or does everything get thrown in here?
There was a problem hiding this comment.
No there is quite a lot of metadata, like the default values for root patterns, filetypes, or other configuration items.
I went with the minimal amount to replicate what we had
There was a problem hiding this comment.
Agreed, we can expand on this in future PRs if there's a need.
| [ | ||
| { | ||
| "cmd": ["als"], | ||
| "desc": "https://github.com/agda/agda-language-server\n\nLanguage Server for Agda.\n", |
There was a problem hiding this comment.
Was just curious because I see they basically always have the website and then a description in here. Made me think about how we provide a link to upstream docs for the plugins and was curious if we could grab the url and strip it out to be used for the proper link instead of crowding the description with it.
There was a problem hiding this comment.
I'd rather to do that in another PR, but it would be better I agree
traxys
force-pushed
the
all-lsp-servers
branch
from
416c398
to
4ef3fa3
Compare
traxys
force-pushed
the
all-lsp-servers
branch
from
4ef3fa3
to
b43fd6c
Compare
This PR allows to auto-generate the list of all lsp servers from the plugin.
The approach taken mirrors the way upstream generates their documentation.
Closes #2163
Closes #2335