Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we're not really testing the
Dockerfile
image directly nor the built images.In our
bats
tests we're just using the Dockerfile to build the sloctl binary and copy it to bats container.Since running dind (Docker in Docker) images has proven tricky to me I've decided to write this basic tests in Go instead.
The tests should only check basic interactions and not cover the larger spectrum that
bats
tests cover.Summary
Updated workflows for e2e tests as well as release workflow.
Testing
Run:
Note that
SLOCTL_E2E_DOCKER_TEST_IMAGE
is optional, if not provided the image will be built withing the test code.Example dispatch runs: