Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add some AdonisJS dependencies #1049

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

RomainLanz
Copy link

@RomainLanz RomainLanz commented Mar 7, 2024

Hey there! 👋🏻

This PR adds some packages required by the AdonisJS Framework to the Gold Mine to ensure that any new Node.js version does not break our code or that we can provide a fix beforehand.

Checklist

Hard Requirements

  • Module source code must be on Github.
  • Published versions must include a tag on Github
  • The test process must be executable with only the commands npm install && npm test or (yarn install && yarn test or pnpm install && pnpm test) using the tarball downloaded from the Github tag mentioned above
  • The tests pass on supported major release lines
  • The maintainers of the module remain responsive when there are problems
  • At least one module maintainer must be added to the lookup maintainers field

Soft Requirements

At least one of:

  • The module must be actively used by the community
  • The module must be heavily depended on
  • The module must cover unique portions of our API
  • The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
  • The module is under the Node.js foundation Github org
  • The module is identified as an important module by a Node.js Working Group

--

  • Contribution guidelines followed here

@mcollina
Copy link
Member

@adonijs/core: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3416/
@adonijs/fold: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3417
@adonijs/http-server: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3418

if the above pass, we can land this PR. If not, you should fix the relative failures and/or limit the platforms that you are targeting.

@RomainLanz
Copy link
Author

RomainLanz commented Apr 15, 2024

I have updated the lookup file to remove platforms we don't plan to work on.

It also seems that osx11-x64 and debian12-x64 reports timeouts for @adonisjs/core. I am not sure what to do about it.

@mcollina
Copy link
Member

I think you can skip osx11-x64. I'm not sure about debian12-x64. There might be some race condition in those tests.

@RomainLanz
Copy link
Author

Could you please re-run the @adonisjs/core test suite to see if it is a flaky test or if there are real issues on that platform?

@mcollina
Copy link
Member

@targos
Copy link
Member

targos commented May 8, 2024

@RomainLanz There are a bunch of errors.

@RomainLanz
Copy link
Author

I known. I haven't got time to see why we have tests timing out in some environments.

Also, I am not sure why the latest run didn't take the latest release that remove the "debug" mode.

@targos
Copy link
Member

targos commented May 8, 2024

Here's a quick run on github actions with the latest release: https://github.com/nodejs/citgm/actions/runs/9004501814

@targos
Copy link
Member

targos commented May 8, 2024

@RomainLanz You can run it locally with node bin/citgm.js @adonisjs/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants