Find VC.Tools.ARM64 on arm64 machine #3075
Open
+475
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm test
passesDescription of change
Fixes #3074
VC.Tools.ARM64
gives the native ARM64 binaries for MSVC, and this patch detects that on arm64 Node.js.Help needed for a test. A fixture that only have ARM64 binary may work but such test would only pass on arm64 test runner machine. And not sure how to generate such fixture. (Just remove x86.x64 from the existing 2022 fixture?)
Also this patch makes some existing tests fail on ARM64 machine because not all fixtures have ARM64 MSVC (as older VS just didn't have it). Help needed for that too. Skip them somehow?Now it falls back to x86 if arm64 tool doesn't exist.