Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix V8 compilation on Apple clang 13 & 14 #288

Open
wants to merge 20 commits into
base: canary
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.18',
'v8_embedder_string': '-node.5',

##### V8 defaults for Node.js #####

Expand Down
4 changes: 4 additions & 0 deletions deps/v8/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
.torquelint-cache
.vscode
/_*
/base
/build
/buildtools
/check-header-includes
Expand Down Expand Up @@ -77,6 +78,8 @@
!/third_party/googletest/src/googletest/include/gtest
/third_party/googletest/src/googletest/include/gtest/*
!/third_party/googletest/src/googletest/include/gtest/gtest_prod.h
!/third_party/highway
/third_party/highway/src
!/third_party/inspector_protocol
!/third_party/jsoncpp
/third_party/jsoncpp/source
Expand All @@ -96,6 +99,7 @@
/tools/luci-go
/tools/oom_dump/oom_dump
/tools/oom_dump/oom_dump.o
/tools/protoc_wrapper
/tools/turbolizer/build
/tools/turbolizer/.rpt2_cache
/tools/turbolizer/deploy
Expand Down
2 changes: 2 additions & 0 deletions deps/v8/.gn
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ no_check_targets = [
]

default_args = {
# Disable js dependencies like the closure compiler.
enable_js_protobuf = false
# Disable rust dependencies.
enable_rust = false
}
Expand Down
7 changes: 6 additions & 1 deletion deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ Alexander Botero-Lowry <[email protected]>
Alexander Karpinsky <[email protected]>
Alexander Neville <[email protected]>
Alexandre Vassalotti <[email protected]>
Alexey Pavlyutkin <[email protected]>
Alexis Campailla <[email protected]>
Allan Sandfeld Jensen <[email protected]>
Amos Lim <[email protected]>
Expand Down Expand Up @@ -100,6 +101,7 @@ Daniel Bevenius <[email protected]>
Daniel Dromboski <[email protected]>
Daniel James <[email protected]>
Daniel Shelton <[email protected]>
Daniil Bakin <[email protected]>
Danylo Boiko <[email protected]>
Darshan Sen <[email protected]>
David Carlier <[email protected]>
Expand Down Expand Up @@ -141,11 +143,11 @@ Henrique Ferreiro <[email protected]>
Helmut Januschka <[email protected]>
Hirofumi Mako <[email protected]>
Hisham Muhammad <[email protected]>
Ho Cheung <[email protected]>
Honggyu Kim <[email protected]>
Huáng Jùnliàng <[email protected]>
HyeockJin Kim <[email protected]>
Iain Ireland <[email protected]>
Ilya Gavrilin <[email protected]>
Ingvar Stepanyan <[email protected]>
Ioseb Dzmanashvili <[email protected]>
Isiah Meadows <[email protected]>
Expand All @@ -168,6 +170,7 @@ Joel Stanley <[email protected]>
Johan Bergström <[email protected]>
Johan Levin <[email protected]>
John Paul Adrian Glaubitz <[email protected]>
Jojo R <[email protected]>
Jonathan Liu <[email protected]>
Juan Arboleda <[email protected]>
Julien Brianceau <[email protected]>
Expand Down Expand Up @@ -203,6 +206,7 @@ Matt Hanselman <[email protected]>
Matthew Sporleder <[email protected]>
Maxim Mazurok <[email protected]>
Maxim Mossienko <[email protected]>
Md Hasibul Hasan <[email protected]>
Meir Shpilraien <[email protected]>
Michael Lutz <[email protected]>
Michael Mclaughlin <[email protected]>
Expand Down Expand Up @@ -258,6 +262,7 @@ Sander Mathijs van Veen <[email protected]>
Sandro Santilli <[email protected]>
Sanjoy Das <[email protected]>
Sam James <[email protected]>
Sébastien Doeraene <[email protected]>
Seo Sanghyeon <[email protected]>
Shawn Anastasio <[email protected]>
Shawn Presser <[email protected]>
Expand Down
Loading
Loading