Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecation warnings and errors flags #402

Closed
wants to merge 4 commits into from

Conversation

lholmquist
Copy link
Member

fixes #322

@lholmquist lholmquist changed the title chore: add deprecation warnings and errors flags WIP - chore: add deprecation warnings and errors flags Mar 19, 2020
@lholmquist
Copy link
Member Author

lholmquist commented Mar 19, 2020

this is a work in progress since circle ci should fail with the given env variables at least for node 12

@lholmquist lholmquist changed the title WIP - chore: add deprecation warnings and errors flags chore: add deprecation warnings and errors flags Mar 19, 2020
@lholmquist
Copy link
Member Author

The failure is because we are creating docs as part of the npm run ci call and the docs are using a deprecated API.

Since this isn't related to Opossum itself, i think we can not do the doc build in the ci tests, which should get around those issues

@lholmquist
Copy link
Member Author

The reason why node 12 is failing here is becuase of this issue, istanbuljs/spawn-wrap#89

Not really anything we can do about it until is fixed

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecations warnings and failures to CI builds
1 participant