make DocumentAST::$hash not nullable

nuwave · Sep 20, 2024 · 289f80a · 289f80a
1 parent c8eb73d
commit 289f80a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/GraphQL.php b/src/GraphQL.php
@@ -392,7 +392,7 @@ protected function parseQuery(string $query): DocumentNode
      */
     protected function validateCacheableRules(
         SchemaType $schema,
-        ?string $schemaHash,
+        string $schemaHash,
         DocumentNode $query,
         ?string $queryHash,
     ): array {
@@ -409,7 +409,7 @@ protected function validateCacheableRules(
 
         $cacheConfig = $this->configRepository->get('lighthouse.validation_cache');
 
-        if ($schemaHash === null || $queryHash === null || ! ($cacheConfig['enable'] ?? false)) {
+        if ($queryHash === null || ! ($cacheConfig['enable'] ?? false)) {
             return DocumentValidator::validate($schema, $query, $validationRules);
         }
 

diff --git a/src/Schema/AST/DocumentAST.php b/src/Schema/AST/DocumentAST.php
@@ -92,7 +92,7 @@ class DocumentAST implements Arrayable
     public array $schemaExtensions = [];
 
     /** A hash of the schema. */
-    public ?string $hash = null;
+    public string $hash;
 
     /** Create a new DocumentAST instance from a schema. */
     public static function fromSource(string $schema): self

diff --git a/src/Schema/SchemaBuilder.php b/src/Schema/SchemaBuilder.php
@@ -28,7 +28,7 @@ public function schema(): Schema
         );
     }
 
-    public function schemaHash(): ?string
+    public function schemaHash(): string
     {
         return $this->astBuilder->documentAST()->hash;
     }