Reset cached values of arguments in BaseDirective::hydrate()

CHANGELOG.md

@@ -9,6 +9,12 @@ You can find and compare releases at the [GitHub release page](https://github.co
 
 ## Unreleased
 
+## v6.16.1
+
+### Fixed
+
+- Reset cached values of arguments in `BaseDirective::hydrate()` https://github.com/nuwave/lighthouse/pull/2430
+
 ## v6.16.0
 
 ### Changed

src/Schema/Directives/BaseDirective.php

@@ -64,6 +64,8 @@ public function hydrate(DirectiveNode $directiveNode, ScalarTypeDefinitionNode|S
         $this->directiveNode = $directiveNode;
         $this->definitionNode = $definitionNode;
 
+        unset($this->directiveArgs);
+
         return $this;
     }
 

tests/Unit/Schema/Directives/BaseDirectiveTest.php

@@ -238,6 +238,30 @@ public function testMutuallyExclusive(): void
         $directive->validateMutuallyExclusiveArguments(['bar', 'baz', 'qux']);
     }
 
+    public function testHydrateShouldResetCachedArgs(): void
+    {
+        $directive = $this->constructFieldDirective('foo: ID @dummy(arg: "value")');
+
+        $this->assertSame(
+            'value',
+            // @phpstan-ignore-next-line protected method is called via wrapper below
+            $directive->directiveArgValue('arg'),
+        );
+
+        $field = Parser::fieldDefinition('foo: ID @dummy(arg: "new value")');
+
+        $directive->hydrate(
+            $field->directives[0],
+            $field,
+        );
+
+        $this->assertSame(
+            'new value',
+            // @phpstan-ignore-next-line protected method is called via wrapper below
+            $directive->directiveArgValue('arg'),
+        );
+    }
+
     protected function constructFieldDirective(string $definition): BaseDirective
     {
         $fieldDefinition = Parser::fieldDefinition($definition);