Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle explicit null in @in directive #2445

Merged
merged 4 commits into from
Sep 9, 2023
Merged

Handle explicit null in @in directive #2445

merged 4 commits into from
Sep 9, 2023

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Sep 9, 2023

Resolves #2444

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Do not apply @in when null is passed.

Breaking changes

None.

@spawnia spawnia added the bug An error within Lighthouse label Sep 9, 2023
@spawnia spawnia mentioned this pull request Sep 9, 2023
Closed
@spawnia spawnia merged commit d2fdb8f into master Sep 9, 2023
27 checks passed
@spawnia spawnia deleted the in-directive-null branch September 9, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An error within Lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@in directive breaks if client sends null
1 participant
@spawnia