Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure deprecationReason is set for arguments #2609

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

owenvoke
Copy link
Contributor

@owenvoke owenvoke commented Sep 2, 2024

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Without this, the deprecationReason is never set, and @deprecated directives for input fields / arguments are stripped from lighthouse:print-schema output.

Breaking changes

@owenvoke owenvoke force-pushed the bugfix/argument-deprecation-reason branch from b35616a to 9dfb0a4 Compare September 2, 2024 10:21
@spawnia spawnia merged commit e6210f7 into nuwave:master Sep 2, 2024
38 checks passed
@spawnia
Copy link
Collaborator

spawnia commented Sep 2, 2024

Thanks, released with https://github.com/nuwave/lighthouse/releases/tag/v6.44.1.

@owenvoke owenvoke deleted the bugfix/argument-deprecation-reason branch September 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants