-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ogenreflect): add new runtime information package #661
Draft
tdakkota
wants to merge
8
commits into
ogen-go:main
Choose a base branch
from
tdakkota:feat/ogenreflect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e407d25 - Browse repository at this point
Copy the full SHA e407d25View commit details -
Configuration menu - View commit details
-
Copy full SHA for de2a9b7 - Browse repository at this point
Copy the full SHA de2a9b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61652a8 - Browse repository at this point
Copy the full SHA 61652a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c1e5ab - Browse repository at this point
Copy the full SHA 3c1e5abView commit details -
perf(gen): use map to store operation info
This is a workaround for `goimports`: it does not treat map lookup as missing package, unlike field lookup of global variable. Otherwise, `goimports` will try to search for the non-existing package and will check every package in GOPATH/module cache. This leads to a very big slowdown. Benchstat: ``` name old time/op new time/op delta Generator/api.github.com-4 13.1s ± 1% 4.7s ± 2% -64.10% (p=0.000 n=13+15) Generator/gotd_bot_api-4 8.63s ± 2% 0.91s ± 3% -89.49% (p=0.000 n=13+15) Generator/tinkoff-4 7.96s ± 3% 0.17s ± 6% -97.90% (p=0.000 n=15+14) Generator/manga-4 7.85s ± 2% 0.05s ± 6% -99.38% (p=0.000 n=14+14) name old alloc/op new alloc/op delta Generator/api.github.com-4 1.95GB ± 0% 1.48GB ± 0% -24.32% (p=0.000 n=15+14) Generator/gotd_bot_api-4 710MB ± 1% 220MB ± 0% -69.07% (p=0.000 n=15+15) Generator/tinkoff-4 537MB ± 2% 41MB ± 3% -92.40% (p=0.000 n=15+15) Generator/manga-4 507MB ± 2% 11MB ± 2% -97.87% (p=0.000 n=15+15) name old allocs/op new allocs/op delta Generator/api.github.com-4 41.1M ± 0% 37.5M ± 0% -8.63% (p=0.000 n=15+13) Generator/gotd_bot_api-4 9.86M ± 0% 6.02M ± 0% -39.01% (p=0.000 n=15+14) Generator/tinkoff-4 5.01M ± 1% 1.15M ± 0% -77.11% (p=0.000 n=15+14) Generator/manga-4 4.17M ± 1% 0.30M ± 0% -92.82% (p=0.000 n=15+15) ```
Configuration menu - View commit details
-
Copy full SHA for 09646a4 - Browse repository at this point
Copy the full SHA 09646a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4522fa - Browse repository at this point
Copy the full SHA d4522faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ec9ddd - Browse repository at this point
Copy the full SHA 3ec9dddView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd89e14 - Browse repository at this point
Copy the full SHA dd89e14View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.