Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roman duris/fix jetson wheel platform #2497

Merged

Conversation

roman-duris
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fixes #2493

Modification

in generate_build_config.py in package_tools change "wheel platform tag" to for "system flag"

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

@RunningLeon RunningLeon added enhancement New feature or request Jetson labels Oct 20, 2023
@RunningLeon
Copy link
Collaborator

@roman-duris Hi, thanks for your PR. Could you sign the cla.

@roman-duris
Copy link
Contributor Author

roman-duris commented Oct 25, 2023

Sorry for the late response and reaction. I had to get approval for CLA, now everything should
de ready for merge @RunningLeon.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit e31f5a6 into open-mmlab:main Oct 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Jetson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Package tools on jetson generate X86_64 wheel which cannot be installed
4 participants