Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to build a project with PyTorch 2.0. #2553

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

Danil328
Copy link
Contributor

Motivation

I use mmdeploy in my project.

Modification

Added the ability to build a project with PyTorch 2.0.
Namely, I added the flag -std=c++17 to extra_compile_args in setup.py depending on the version of Torch like mmcv setup.py.
https://github.com/open-mmlab/mmcv/blob/main/setup.py#L203

Namely, I added the flag -std=c++17 to extra_compile_args
 depending on the version of Torch.
@CLAassistant
Copy link

CLAassistant commented Nov 17, 2023

CLA assistant check
All committers have signed the CLA.

@RunningLeon
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

hi, thanks for your PR. Could you sign the cla?
Best regards.

@irexyc
Copy link
Collaborator

irexyc commented Nov 24, 2023

You forget to import parse_version.
May fix it and check if the ci could pass.

@Danil328
Copy link
Contributor Author

Danil328 commented Nov 27, 2023

You forget to import parse_version. May fix it and check if the ci could pass.

Thank you very much, import added.
Can you start workflows?

"12 workflows awaiting approval"

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 660af62 into open-mmlab:main Nov 30, 2023
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants