interpreters, reporter: refactor towards statelessness #171
+268
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabled
changed the title
fabled
force-pushed
the
tt-interpreter-metadata
branch
from
4b62fd0
to
4823881
Compare
4 tasks
Due to legacy reasons, each interpreter kept their own state of which dynamic metadata should be sent to the reporter. Several of these caches would never expire, causing caching issues in the otlp reporter module. This removes the caching state from all interpreters and pushes it to the reporter module. A new reporter API call FrameNeeded is added to query if a specific Frame is in the cache or not. Not all interpreter modules use the call as all the information might be available with little overhead. FrameMetadata is also updated to use the FrameID type for symmetry. Improved are: - reduced memory overhead as per-interpreter caches are removed - reporter module can now control which frames need resolving - fixes otlp to get the frames re-symbolized if its internal lru already forgot about the earlier symbolization information ref open-telemetry#121
fabled
force-pushed
the
tt-interpreter-metadata
branch
from
4823881
to
f87d97b
Compare
rockdaboot
approved these changes
Oct 2, 2024
rockdaboot
reviewed
Oct 2, 2024
interpreter/dotnet/instance.go
Outdated
| @@ -764,19 +756,16 @@ func (i *dotnetInstance) Symbolize(symbolReporter reporter.SymbolReporter, | |||
| if err != nil { | |||
| return err | |||
| } | |||
| fileID := module.fileID | |||
| // The Line ID is the Relative Virtual Address (RVA) within into the PE file | |||
There was a problem hiding this comment.
Suggested change
| // The Line ID is the Relative Virtual Address (RVA) within into the PE file | |
| // The Line ID is the Relative Virtual Address (RVA) within the PE file |
Comment on lines
+169
to
+172
| h := fnv.New128a() | ||
| _, _ = h.Write([]byte(name)) | ||
| nameHash := h.Sum(nil) | ||
| lineID = libpf.AddressOrLineno(npsr.Uint64(nameHash, 0)) |
There was a problem hiding this comment.
Does it make sense to have an extra function for this?
There was a problem hiding this comment.
The same pattern is written out in several interpreter modules. It might make sense to make a helper for this in the interpreter or libpf module. But I'd make it a separate / follow up PR instead since its logically a separate thing.
|
Addressed feedback: comments updated and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to legacy reasons, each interpreter kept their own state of which dynamic metadata should be sent to the reporter. Several of these caches would never expire, causing caching issues in the otlp reporter module.
This removes the caching state from all interpreters and pushes it to the reporter module. A new reporter API call FrameNeeded is added to query if a specific Frame is in the cache or not. Not all interpreter modules use the call as all the information might be available with little overhead. FrameMetadata is also updated to use the FrameID type for symmetry.
Improved are:
ref #121