feat(localpv): Add regex to handle zstd levels [1-19] #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnels124
force-pushed
the
zstd-levels
branch
2 times, most recently
from
0414907
to
40701cb
Compare
|
Hey @jnels124, thank you for your contribution! Could you please rebase your PR please? Thanks.. |
|
@niladrih I have rebased my branch. |
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
|
@niladrih believe there was an error in my previous rebase. I have fixed. |
hrudaya21
approved these changes
Jul 24, 2023
This is the default recordsize for ZFS datasets, and significantly better for most use-cases than 4k. Signed-off-by: Andrew LeCody <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Reason: - v1 CSIStorageCapacity is GA since K8s 1.24 and in csi-provisioner 3.2.0 and above. - In K8s 1.27 v1beta1/CSIStorageCapacity has been removed, so bumping this up will enable zfs-localpv to run on K8s 1.27 & above. Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
|
These changes have been included in #461, closing this one. This is available in the released version v2.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Please, go through these steps before you submit a PR.
Why is this PR required? What issue does it fix?:
allow setting the compression to zstd with levels
What this PR does?:
Updates CRDs for volumes, snapshots, and restores to allow zstd compression with specific level
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Manually applied CRD's (also re ran verification steps when using helm)
Edited existing zv with compression set to zstd-12. Verified the zpool on the node was updated accordingly.
Performed write tests with known compressed size and confirmed compression level change was applied to new data.
Any additional information for your reviewer? :
Checklist:
<type>(<scope>): <subject>