Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameter overflow in divsqrt_multi #106

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sifferman
Copy link

Hello!

Issue

Commits 51e6ba8 and 1548dae from PR #102 have introduced a bug due to the use of NUM_INP_REGS-1 without checking NUM_INP_REGS > 0.

This causes the basic instantiation example to fail in DC due to Error: fpnew_divsqrt_multi.sv: integer overflow occurs. (ELAB-210).

Fix

I now split all 3 references to reg_ena_i[NUM_INP_REGS-1] into a new signal last_reg_ena that is forced to 1'b0 if NUM_INP_REGS==0.

Now the basic instantiation example once again is synthesizable.

Thanks!

Copy link

@pascalgouedo pascalgouedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PULP DIV/SQRT not used in CV32E40P.

Letting people using it approve it or not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants