🐛 Fix status flags for I2F and F2I conversions #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmach
requested changes
Aug 22, 2024
michael-platzer
force-pushed
the
fix/cast-multi-status-flags
branch
from
0e2d2c7
to
daf6b91
Compare
michael-platzer
force-pushed
the
fix/cast-multi-status-flags
branch
from
daf6b91
to
1f1b637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #123 by correcting the assignment of floating-point status flags on
I2FandF2Iconversions, which is currently not compliant with IEEE 754-2008 as detailed in the linked issue.