-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334332: TestIOException.java fails if run by root #2795
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
@sendaoYan Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
/approval request Clean backport of JDK-8334332, make the testcase more robustness, almost no risk. |
@sendaoYan |
Thanks for the approved. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, can anyone take a look this backport. |
1 similar comment
Hi, can anyone take a look this backport. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
Hi all,
This pull request contains a backport of commit 472b935b from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.
The reason of backport is not clean is that, multiple PRs have been merged into the
jdk17u-dev
of this file, includingJDK-8215516
,JDK-8164597
, etc., and these PRs cannot be directly backported tojdk11u-dev
.This PR also change
test/langtools/TEST.ROOT
, it's partial backport of JDK-8242652. JDK-8242652 can't backport to jdk11u-dev, the jdk11u-dev repo dosen't have filetest/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java
.Only change test testcase, the risk is quite very low.
The change verified on below env:
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2795/head:pull/2795
$ git checkout pull/2795
Update a local copy of the PR:
$ git checkout pull/2795
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2795/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2795
View PR using the GUI difftool:
$ git pr show -t 2795
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2795.diff
Webrev
Link to Webrev Comment