Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334332: TestIOException.java fails if run by root #2795

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 18, 2024

Hi all,

This pull request contains a backport of commit 472b935b from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 18 Jun 2024 and was reviewed by Pavel Rappo.

The reason of backport is not clean is that, multiple PRs have been merged into the jdk17u-dev of this file, including JDK-8215516, JDK-8164597, etc., and these PRs cannot be directly backported to jdk11u-dev.

This PR also change test/langtools/TEST.ROOT, it's partial backport of JDK-8242652. JDK-8242652 can't backport to jdk11u-dev, the jdk11u-dev repo dosen't have file test/langtools/jdk/javadoc/doclet/testSearchScript/TestSearchScript.java.

Only change test testcase, the risk is quite very low.

The change verified on below env:

  • linux non-root user
  • linix root user
  • windows

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334332 needs maintainer approval

Issue

  • JDK-8334332: TestIOException.java fails if run by root (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2795/head:pull/2795
$ git checkout pull/2795

Update a local copy of the PR:
$ git checkout pull/2795
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2795/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2795

View PR using the GUI difftool:
$ git pr show -t 2795

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2795.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 472b935b442f7f925b665c7de91eda77f3dcbe8b 8334332: TestIOException.java fails if run by root Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 18, 2024
@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@sendaoYan Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@mlbridge
Copy link

mlbridge bot commented Jun 18, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport of JDK-8334332, make the testcase more robustness, almost no risk.

@openjdk
Copy link

openjdk bot commented Jun 18, 2024

@sendaoYan
8334332: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Jun 18, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approved.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone take a look this backport.

1 similar comment
@sendaoYan
Copy link
Member Author

Hi, can anyone take a look this backport.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@sendaoYan This pull request is already open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant