Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312049: runtime/logging/ClassLoadUnloadTest can be improved #2920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented Aug 23, 2024

Backport that improves ClassLoadUnloadTest; already backported to JDK21 and JDK17. Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later version, thus these cases are excluded. Some args in exec() also were not added until a later version, thus they are excluded. Additionally, these flags were deprecated in a later version and thus removed from this test; simple modifications are added so that these later removed cases follow the backport logic. Affected test passes.

MacOS GHA not passing due to unrelated deprecated sprintf


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312049 needs maintainer approval

Issue

  • JDK-8312049: runtime/logging/ClassLoadUnloadTest can be improved (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2920/head:pull/2920
$ git checkout pull/2920

Update a local copy of the PR:
$ git checkout pull/2920
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2920/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2920

View PR using the GUI difftool:
$ git pr show -t 2920

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2920.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4676b40f17dd18941f5883cb9b989ad639992a50 8312049: runtime/logging/ClassLoadUnloadTest can be improved Aug 23, 2024
@openjdk
Copy link

openjdk bot commented Aug 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 23, 2024
@cost0much cost0much marked this pull request as ready for review August 23, 2024 20:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 23, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2024

Webrevs

@phohensee
Copy link
Member

MacOS GHA build failures are sprintf related, i.e., not related to this backport.

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@cost0much
Copy link
Contributor Author

/approval request Improves the test added by JDK-8312049 in JDK22. Does not apply cleanly, but the manual resolutions are simple and have been investigated. Affected test passes. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

@cost0much
8312049: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 27, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants