-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8312049: runtime/logging/ClassLoadUnloadTest can be improved #2920
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
MacOS GHA build failures are sprintf related, i.e., not related to this backport. |
|
/approval request Improves the test added by JDK-8312049 in JDK22. Does not apply cleanly, but the manual resolutions are simple and have been investigated. Affected test passes. Risk is low: the change is test code only. |
@cost0much |
@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Backport that improves ClassLoadUnloadTest; already backported to JDK21 and JDK17. Original commit does not apply cleanly due to the options "-Xlog:class+load+cause" "-Xlog:class+load+cause+native" were not added until a later version, thus these cases are excluded. Some args in exec() also were not added until a later version, thus they are excluded. Additionally, these flags were deprecated in a later version and thus removed from this test; simple modifications are added so that these later removed cases follow the backport logic. Affected test passes.
MacOS GHA not passing due to unrelated deprecated sprintf
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2920/head:pull/2920
$ git checkout pull/2920
Update a local copy of the PR:
$ git checkout pull/2920
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2920/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2920
View PR using the GUI difftool:
$ git pr show -t 2920
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2920.diff
Webrev
Link to Webrev Comment